From 7b7171c1091a8c9830577c079d982cb711729c9e Mon Sep 17 00:00:00 2001
From: Corey Blais <corey@blaishome.online>
Date: Wed, 3 Jun 2026 11:54:44 -0400
Subject: [PATCH] Prevent report card text overlap

---
 backend/src/reports/adoptionReport.ts | 40 ++++++++++++++++++---------
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/backend/src/reports/adoptionReport.ts b/backend/src/reports/adoptionReport.ts
index aebf9e8..1e1ff8e 100644
--- a/backend/src/reports/adoptionReport.ts
+++ b/backend/src/reports/adoptionReport.ts
@@ -97,10 +97,26 @@ const fitText = (doc: PDFKit.PDFDocument, text: string, x: number, y: number, wi
   return doc.y;
 };
 
-const drawFact = (doc: PDFKit.PDFDocument, label: string, value: string, x: number, y: number, width: number) => {
-  doc.roundedRect(x, y, width, 43, 6).fillAndStroke(colors.panel, colors.border);
+const measureFactHeight = (doc: PDFKit.PDFDocument, value: string, width: number, minHeight = 43) => {
+  doc.font('Helvetica-Bold').fontSize(10);
+  const textHeight = doc.heightOfString(value, {
+    width: width - 16,
+    lineGap: 1,
+  });
+  return Math.max(minHeight, 27 + Math.min(textHeight, 38));
+};
+
+const drawFact = (doc: PDFKit.PDFDocument, label: string, value: string, x: number, y: number, width: number, height?: number) => {
+  const cardHeight = height ?? measureFactHeight(doc, value, width);
+  doc.roundedRect(x, y, width, cardHeight, 6).fillAndStroke(colors.panel, colors.border);
   doc.fillColor(colors.muted).fontSize(7).font('Helvetica-Bold').text(label.toUpperCase(), x + 8, y + 8, { width: width - 16 });
-  doc.fillColor(colors.ink).fontSize(10).font('Helvetica-Bold').text(value, x + 8, y + 21, { width: width - 16, ellipsis: true });
+  doc.fillColor(colors.ink).fontSize(10).font('Helvetica-Bold').text(value, x + 8, y + 21, {
+    width: width - 16,
+    height: cardHeight - 27,
+    lineGap: 1,
+    ellipsis: true,
+  });
+  return cardHeight;
 };
 
 const drawTextCard = (doc: PDFKit.PDFDocument, label: string, value: string, x: number, y: number, width: number, height = 58) => {
@@ -351,16 +367,14 @@ export const renderAdoptionReportPdf = async ({
     y = page.margin;
   }
   y = drawSectionTitle(doc, 'Veterinary Clinic Info', y);
-  const vetFacts = [
-    ['Clinic name', bird.vet_clinic_name || 'Not recorded'],
-    ['Clinic address', bird.vet_clinic_address || 'Not recorded'],
-    ['Account #', bird.vet_account_number || 'Not recorded'],
-    ['Dr. name', bird.vet_doctor_name || 'Not recorded'],
-  ];
-  vetFacts.forEach(([label, value], index) => {
-    drawFact(doc, label, value, page.margin + (index % 2) * (factWidth + factGap), y + Math.floor(index / 2) * 50, factWidth);
-  });
-  y += Math.ceil(vetFacts.length / 2) * 50 + 8;
+  drawFact(doc, 'Clinic name', bird.vet_clinic_name || 'Not recorded', page.margin, y, factWidth);
+  drawFact(doc, 'Account #', bird.vet_account_number || 'Not recorded', page.margin + factWidth + factGap, y, factWidth);
+  y += 50;
+  const clinicAddressHeight = measureFactHeight(doc, bird.vet_clinic_address || 'Not recorded', contentWidth, 58);
+  drawFact(doc, 'Clinic address', bird.vet_clinic_address || 'Not recorded', page.margin, y, contentWidth, clinicAddressHeight);
+  y += clinicAddressHeight + 7;
+  drawFact(doc, 'Dr. name', bird.vet_doctor_name || 'Not recorded', page.margin, y, factWidth);
+  y += 50;
 
   y = drawSectionTitle(doc, 'Vet Visit History', y);
   y = drawTable(