changed weight reminder schedule

backend/test-integration/weightReminders.mjs

@@ -14,11 +14,13 @@ Object.assign(process.env, {
   SMTP_USER: '', SMTP_PASS: '', SMTP_FROM_EMAIL: 'reminders@flockpal.test', SMTP_FROM_NAME: 'FlockPal Test',
   FRONTEND_URL: 'http://flockpal.test', MILESTONE_REMINDERS_ENABLED: 'false',
   MEDICATION_REMINDERS_ENABLED: 'false', WEIGHT_REMINDERS_ENABLED: 'true',
+  MILESTONE_REMINDER_TIME_ZONE: 'America/New_York',
 });
 const { db } = await import('../dist/db/client.js');
 const { ensureSchema } = await import('../dist/db/schema.js');
+const { getReminderDate } = await import('../dist/reminders/reminderDate.js');
 const { listDueWeightReminders, claimWeightReminder, finishWeightReminder } = await import('../dist/reminders/weightReminders.js');
-const { weightReminderQueue, startWeightReminderScheduler } = await import('../dist/queues/weightReminderQueue.js');
+const { weightReminderQueue, startWeightReminderScheduler, enqueueDailyWeightReminder } = await import('../dist/queues/weightReminderQueue.js');
 const workers = [];
 let logs = '';
 const poll = async (check, label) => {
@@ -91,6 +93,8 @@ try {
   await finishWeightReminder(tokens[claims.indexOf(true)], false);
   console.log('PASS: schema initialization is repeatable; eligibility, roles, and concurrent claims');
 
+  // Simulate the schedule present before upgrading to daily reminders.
+  await weightReminderQueue.upsertJobScheduler('weight-reminders', { every: 300_000 }, { name: 'check-overdue-weights', data: {} });
   startWorker(); startWorker();
   await poll(async () => (await messages()).length === 4, 'initial grouped emails');
   await drain();
@@ -110,22 +114,26 @@ try {
     }
     assert.equal(body.To.length, 1);
   }
-  assert.equal((await weightReminderQueue.getJobSchedulers()).length, 1);
+  assert.equal((await weightReminderQueue.getJobSchedulers()).length, 0);
+  await poll(async () => Boolean(await weightReminderQueue.getJob(`weight-reminders-${getReminderDate()}`)), 'startup daily scheduler');
+  const dailyJobs = await Promise.all([enqueueDailyWeightReminder(), enqueueDailyWeightReminder()]);
+  assert.equal(dailyJobs[0].id, dailyJobs[1].id);
+  await drain();
   assert.equal(await weightReminderQueue.getGlobalConcurrency(), 1);
   assert.equal((await runJob()).sent, 0);
   assert.equal((await messages()).length, 4);
-  console.log('PASS: two real workers, one scheduler, grouped SMTP delivery, escaping, flock isolation, no immediate duplicates');
+  console.log('PASS: two real workers, one daily job, legacy schedule removed, grouped SMTP delivery, escaping, flock isolation, no immediate duplicates');
 
-  await db.query("UPDATE weight_reminder_deliveries SET delivered_at = CURRENT_TIMESTAMP - INTERVAL '47 hours'");
+  await db.query("UPDATE weight_reminder_deliveries SET delivered_at = CURRENT_TIMESTAMP");
   assert.equal((await runJob()).sent, 0);
-  await db.query("UPDATE weight_reminder_deliveries SET delivered_at = CURRENT_TIMESTAMP - INTERVAL '48 hours'");
+  await db.query("UPDATE weight_reminder_deliveries SET delivered_at = ((CURRENT_TIMESTAMP AT TIME ZONE 'America/New_York')::date::timestamp AT TIME ZONE 'America/New_York') - INTERVAL '1 second'");
   assert.equal((await runJob()).sent, 4);
   assert.equal((await messages()).length, 8);
   await db.query("INSERT INTO weight_records (bird_id, weight_grams, recorded_on) VALUES ($1, 91, CURRENT_DATE)", [birds.Boundary]);
   await db.query("UPDATE weight_reminder_deliveries SET delivered_at = CURRENT_TIMESTAMP - INTERVAL '49 hours'");
   assert.ok((await listDueWeightReminders()).every(b => b.bird_id !== birds.Boundary));
   assert.equal((await runJob()).sent, 4);
-  console.log('PASS: no repeat before 48 hours, repeat after 48 hours, fresh weight resets eligibility');
+  console.log('PASS: no repeat on the same local date, daily repeat, fresh weight resets eligibility');
 
   await stopWorkers();
   await db.query("UPDATE weight_reminder_deliveries SET delivered_at = CURRENT_TIMESTAMP - INTERVAL '49 hours'");